OpenVAS Libraries  4.0+rc3.SVN
Todo List
Global _ (abc)

Resolve workaround, real i18n

Resolve workaround, real i18n

Global accessrule_as_xml (const accessrule_t *)
Use g_markup_escape here
Global accessrule_as_xml (const accessrule_t *)
Use g_markup_escape here
Global accessrules_from_file (gchar *)

Create a access_rules_t* and pass as user data

error checks, handling

Global accessrules_from_file (gchar *)

Create a access_rules_t* and pass as user data

error checks, handling

Global ACT_LAST
Consider creation of an enumeration.
Global certificate_create (void)
Correct doc or implementation for the set_* methods, they always return 0.
Global certificate_create (void)
Correct doc or implementation for the set_* methods, they always return 0.
Global check_response (gnutls_session_t *session)
Use this in the other functions.
Global DO_CHILDREN (entity, child, temp, body)
Use next_entities and first_entity instead of this.
Global FIX (n)
: It still needs to be taken care BSD_BYTE_ORDERING gets here if defined (e.g. by config.h)
Global G_LOG_DOMAIN

Ensure that every global init gets a free.

This module nearly fulfils the requirements to be placed in the base library (the gnutls dependency makes it a candidate for the net library).

File hash_table_util.c

Note that some of the code might get obsolete with future version of GLib.

This module is a candidate for a util library (as it is not specific to OPENVAS).

Global hg_add_host_with_options (struct hg_globals *globals, char *hostname, struct in_addr ip, int alive, int netmask, int use_max, struct in_addr *ip_max)
consider const for hostname parameter
Global hg_add_ipv6host_with_options (struct hg_globals *globals, char *hostname, struct in6_addr *ip, int alive, int netmask, int use_max, struct in6_addr *ip_max)
We will probably segfault sooner or later if inet_ntop fails.
Global IMPORT (var)
Check for memleak and document reference counting in tree cells. In some cases, after a tree_cell (typically retc) has been allocated with alloc_tree_cell, it is not later freed or deref_tree_cell'ed. It has to evaluated if that is okay or leads to memory leaks.
Global kb_item::v
Check if this is safe. (What happens if char* and int have not the same size?)
Global keys_as_string_list (GHashTable *hash_table, GCompareFunc cmp_func)
Note that with GLib 2.14 this function is obsolete, as Glib 2.14 defines g_hash_table_get_keys ().
Global main (int argc, char *argv[])
forgot to break here?
Global nasl_chomp (lex_ctxt *lexic)
evaluate early break
Global nasl_smb_versioninfo (lex_ctxt *lexic)
Check for memleak and document reference counting in tree cells. In some cases, after a tree_cell (typically retc) has been allocated with alloc_tree_cell, it is not later freed or deref_tree_cell'ed. It has to evaluated if that is okay or leads to memory leaks.
Global nvti_as_openvas_nvt_cache_entry (const nvti_t *)
return A newly allocated string The string needs to be freed with g_free().
Global nvti_as_openvas_nvt_cache_entry (const nvti_t *)
return A newly allocated string The string needs to be freed with g_free().
Global nvti_to_keyfile (const nvti_t *, const gchar *)
Anything else indicates an error.
Global nvti_to_keyfile (const nvti_t *, const gchar *)
Anything else indicates an error.
Global OCTETRANGE
Document what kind of input for ipv6 adresses is acceppted, move description of valid "hostnames" to a better place (this is really interesting for a user), document how to list multiple hosts (space, comma, semicolon- separated?).
File omp.c
Name functions consistently (perhaps omp_*).
Global omp_get_report_format (gnutls_session_t *session, const char *id, const char *format, void **report, gsize *report_size)
This now has a bad name, because there is an OMP GET_REPORT_FORMATS.
Global omp_wait_for_task_start (gnutls_session_t *session, const char *id)
Reconsider this (more below).
Global openvas_auth_store_user_rules (const gchar *user_dir_name, const gchar *hosts, int hosts_allow)
Do better format checking on hosts.
Global openvas_auth_tear_down ()
Close memleak, destroy list and content.
Global openvas_auth_user_rules (const gchar *username, gchar **rules)
access error message here, or pass it up.
Global openvas_auth_user_uuid_rules (const gchar *username, const gchar *user_uuid, gchar **rules)
access error message here, or pass it up.
Global openvas_auth_write_config (GKeyFile *key_file)
Preserve comments in file.
File openvas_certificate_file.c
Re-enable error reporting (currently commented, show_error)
Global openvas_file_check_is_dir (const char *name)
FIXME: handle symbolic links
Global openvas_file_remove_recurse (const gchar *pathname)
Set errno when we return -1 to maintain remove() compatibility.
Global openvas_log_func (const char *log_domain, GLogLevelFlags log_level, const char *message, gpointer openvas_log_config_list)

Move log_separator to the conf file too.

Check what error this is.

File openvas_logging.c
This module fulfils the reqirements to be placed in the base library.
Global openvas_server_free (int, gnutls_session_t, gnutls_certificate_credentials_t)
vs openvas_server_close
Global openvas_server_free (int, gnutls_session_t, gnutls_certificate_credentials_t)
vs openvas_server_close
Global openvas_server_open (gnutls_session_t *, const char *, int)

Ensure that host and port have sane values.

Improve logging.

Use openvas_server_new.

Use openvas_server_connect.

Global openvas_server_open (gnutls_session_t *, const char *, int)

Ensure that host and port have sane values.

Improve logging.

Use openvas_server_new.

Use openvas_server_connect.